Hmm, the tests are failing on Puppeteer. I’ll take a look tomorrow to try to understand why. Do you have any idea why the second amOnPage doesn’t pass? I’m not very familiar with Puppeteer.

For Puppeteer, I think I may have identified the issue, but I’d like confirmation since I’m not an expert in Puppeteer or the Codecept recorder.

In this helper we set await this.page.setRequestInterception(true):

However, when we stop, we never set this value back to false:

My proposal is to modify it like this:

async stopRecordingTraffic() {
  await this.page.setRequestInterception(false);
  stopRecordingTraffic.call(this);
}

From what I’ve read, if requestInterception is set to true, we must always handle the requests. That means we should reset it to false when we flush the listeners: puppeteer/puppeteer#2055 (comment)

The tests passed with this modification, but I have one last question: what would be the impact of making stopRecordingTraffic asynchronous?

For Puppeteer, I think I may have identified the issue, but I’d like confirmation since I’m not an expert in Puppeteer or the Codecept recorder.

In this helper we set await this.page.setRequestInterception(true):

CodeceptJS/lib/helper/Puppeteer.js

Lines 2602 to 2610 in 15a288e

	async startRecordingTraffic() {
	this.flushNetworkTraffics()
	this.recording = true
	this.recordedAtLeastOnce = true
	await this.page.setRequestInterception(true)
	this.page.on('request', request => {
	const information = {

However, when we stop, we never set this value back to false:

CodeceptJS/lib/helper/Puppeteer.js

Lines 2594 to 2596 in 15a288e

	stopRecordingTraffic() {
	stopRecordingTraffic.call(this)
	}

My proposal is to modify it like this:

async stopRecordingTraffic() {
  await this.page.setRequestInterception(false);
  stopRecordingTraffic.call(this);
}

From what I’ve read, if requestInterception is set to true, we must always handle the requests. That means we should reset it to false when we flush the listeners: puppeteer/puppeteer#2055 (comment)

The tests passed with this modification, but I have one last question: what would be the impact of making stopRecordingTraffic asynchronous?

thanks for pointing it out @Samuel-StO, maybe it's a missing piece when trying to consolidate the actions to be shared among Puppeteer, Playwright and WebDriver helpers -> https://github.com/codeceptjs/CodeceptJS/pull/4263/files#diff-8b5994d9478083cafc2a9a5943b10cbff2648e67b092689c43e5f3d8924b4096R107